Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit error message for async recursion. #62871

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Explicit error message for async recursion. #62871

merged 1 commit into from
Jul 29, 2019

Conversation

gilescope
Copy link
Contributor

Attempt at clearer error message when async recusion is attempted. In response to #62539 (and #53690).

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2019
@gilescope
Copy link
Contributor Author

gilescope commented Jul 22, 2019 •
edited
Loading

@nikomatsakis thoughts on the extened error explanation? I made it simple enough that I'd be able to follow it. I'm tempted to put the link to the async book in the extended error info rather than directly in the error message as there's now two "For more info see" in the current message.

@petrochenkov
Copy link
Contributor

r? @cramertj

@rust-highfive

This comment has been minimized.

Sign in to view
Centril
Centril reviewed Jul 22, 2019
View reviewed changes
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
src/librustc_typeck/error_codes.rs Outdated Show resolved Hide resolved
src/librustc_typeck/error_codes.rs Outdated Show resolved Hide resolved
src/test/ui/generator/async-recursion-forbid.rs Outdated Show resolved Hide resolved
src/test/ui/generator/async-recursion-forbid.rs Outdated Show resolved Hide resolved
src/test/ui/generator/async-recursion-forbid.rs Outdated Show resolved Hide resolved
@Centril
Copy link
Contributor

Centril commented Jul 22, 2019

r? @Centril since I already did a review... :)

@rust-highfive rust-highfive assigned Centril and unassigned cramertj Jul 22, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril

This comment has been minimized.

Sign in to view
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@gilescope
Copy link
Contributor Author

I seem to have managed to repro #57151 accidentally. Could some one kick bors and just confirm this is repeatable. If so will start digging...

@Centril Centril closed this Jul 24, 2019
@Centril Centril reopened this Jul 24, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril

This comment has been minimized.

Sign in to view
@estebank

This comment has been minimized.

Sign in to view
@GuillaumeGomez

This comment has been minimized.

Sign in to view
nikomatsakis
nikomatsakis approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, lgtm!

src/librustc_typeck/error_codes.rs Outdated Show resolved Hide resolved
src/librustc_typeck/error_codes.rs Outdated Show resolved Hide resolved
@gilescope

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@gilescope

This comment has been minimized.

Sign in to view
@Centril

This comment has been minimized.

Sign in to view
@gilescope gilescope mentioned this pull request Jul 26, 2019
Merged
@rust-highfive

This comment has been minimized.

Sign in to view
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
@Centril
Rollup merge of rust-lang#63002 - gilescope:better-build-diagnostics,…
8882e42 
… r=Mark-Simulacrum

error_index_generator should output stdout/stderr when it panics.

**bootstrap change**

Call error_index_generator tool using run_quiet which will additionally print std out and std err of the command when it returns an error.
(was `run` uses `run_silent` under the covers.)

Why: PR rust-lang#62871 is hitting a build error but the panic isn't getting shown so its unclear what the problem is.
@ollie27

This comment has been minimized.

Sign in to view
@gilescope

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@gilescope
Copy link
Contributor Author

Thanks @ollie27 for spotting that. Stick a fork in the PR - I think it's done.

@Centril
Copy link
Contributor

Centril commented Jul 28, 2019

Indeed it is, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jul 28, 2019

📌 Commit 4b1d404 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 28, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 28, 2019
@Centril
Rollup merge of rust-lang#62871 - gilescope:async-recursion-error, r=…
2ac9b89 
…Centril

Explicit error message for async recursion.

Attempt at clearer error message when async recusion is attempted. In response to rust-lang#62539 (and rust-lang#53690).
@Centril Centril mentioned this pull request Jul 28, 2019
Merged
bors added a commit that referenced this pull request Jul 28, 2019
@bors
Auto merge of #63090 - Centril:rollup-xnjwm2h, r=Centril
c7312fe 
Rollup of 8 pull requests

Successful merges:

 - #61856 (Lint attributes on function arguments)
 - #62360 (Document that ManuallyDrop::drop should not called more than once)
 - #62392 (Update minifier-rs version)
 - #62871 (Explicit error message for async recursion.)
 - #62995 (Avoid ICE when suggestion span is at Eof)
 - #63053 (SystemTime docs: recommend Instant for elapsed time)
 - #63081 (tidy: Cleanup the directory whitelist)
 - #63088 (Remove anonymous_parameters from unrelated test)

Failed merges:

r? @ghost
@bors bors merged commit 4b1d404 into rust-lang:master Jul 29, 2019
@Centril Centril mentioned this pull request Jul 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cramertj cramertj cramertj left review comments

@Centril Centril Centril left review comments

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@gilescope @rust-highfive @petrochenkov @Centril @estebank @GuillaumeGomez @ollie27 @bors @nikomatsakis @cramertj